136 lines
3.9 KiB
Plaintext
136 lines
3.9 KiB
Plaintext
'use strict';
|
|
|
|
var utils = require('../utils.js');
|
|
require('eslint-visitor-keys');
|
|
require('espree');
|
|
require('estraverse');
|
|
|
|
const ARITHMETIC_OPERATORS = ["+", "-", "*", "/", "%", "**"];
|
|
const BITWISE_OPERATORS = ["&", "|", "^", "~", "<<", ">>", ">>>"];
|
|
const COMPARISON_OPERATORS = ["==", "!=", "===", "!==", ">", ">=", "<", "<="];
|
|
const LOGICAL_OPERATORS = ["&&", "||"];
|
|
const RELATIONAL_OPERATORS = ["in", "instanceof"];
|
|
const TERNARY_OPERATOR = ["?:"];
|
|
const COALESCE_OPERATOR = ["??"];
|
|
const ALL_OPERATORS = [].concat(
|
|
ARITHMETIC_OPERATORS,
|
|
BITWISE_OPERATORS,
|
|
COMPARISON_OPERATORS,
|
|
LOGICAL_OPERATORS,
|
|
RELATIONAL_OPERATORS,
|
|
TERNARY_OPERATOR,
|
|
COALESCE_OPERATOR
|
|
);
|
|
const DEFAULT_GROUPS = [
|
|
ARITHMETIC_OPERATORS,
|
|
BITWISE_OPERATORS,
|
|
COMPARISON_OPERATORS,
|
|
LOGICAL_OPERATORS,
|
|
RELATIONAL_OPERATORS
|
|
];
|
|
const TARGET_NODE_TYPE = /^(?:Binary|Logical|Conditional)Expression$/u;
|
|
function normalizeOptions(options = {}) {
|
|
const hasGroups = options.groups && options.groups.length > 0;
|
|
const groups = hasGroups ? options.groups : DEFAULT_GROUPS;
|
|
const allowSamePrecedence = options.allowSamePrecedence !== false;
|
|
return {
|
|
groups,
|
|
allowSamePrecedence
|
|
};
|
|
}
|
|
function includesBothInAGroup(groups, left, right) {
|
|
return groups.some((group) => group.includes(left) && group.includes(right));
|
|
}
|
|
function getChildNode(node) {
|
|
return node.type === "ConditionalExpression" ? node.test : node.left;
|
|
}
|
|
var noMixedOperators = utils.createRule({
|
|
name: "no-mixed-operators",
|
|
package: "js",
|
|
meta: {
|
|
type: "layout",
|
|
docs: {
|
|
description: "Disallow mixed binary operators"
|
|
},
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
groups: {
|
|
type: "array",
|
|
items: {
|
|
type: "array",
|
|
items: {
|
|
type: "string",
|
|
enum: ALL_OPERATORS
|
|
},
|
|
minItems: 2,
|
|
uniqueItems: true
|
|
},
|
|
uniqueItems: true
|
|
},
|
|
allowSamePrecedence: {
|
|
type: "boolean",
|
|
default: true
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
messages: {
|
|
unexpectedMixedOperator: "Unexpected mix of '{{leftOperator}}' and '{{rightOperator}}'. Use parentheses to clarify the intended order of operations."
|
|
}
|
|
},
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const options = normalizeOptions(context.options[0]);
|
|
function shouldIgnore(node) {
|
|
const a = node;
|
|
const b = node.parent;
|
|
return !includesBothInAGroup(
|
|
options.groups ?? [],
|
|
a.operator,
|
|
b.type === "ConditionalExpression" ? "?:" : b.operator
|
|
) || options.allowSamePrecedence && utils.getPrecedence(a) === utils.getPrecedence(b);
|
|
}
|
|
function isMixedWithParent(node) {
|
|
return node.operator !== node.parent.operator && !utils.isParenthesised(sourceCode, node);
|
|
}
|
|
function getOperatorToken(node) {
|
|
return sourceCode.getTokenAfter(getChildNode(node), utils.isNotClosingParenToken);
|
|
}
|
|
function reportBothOperators(node) {
|
|
const parent = node.parent;
|
|
const left = getChildNode(parent) === node ? node : parent;
|
|
const right = getChildNode(parent) !== node ? node : parent;
|
|
const data = {
|
|
leftOperator: left.operator || "?:",
|
|
rightOperator: right.operator || "?:"
|
|
};
|
|
context.report({
|
|
node: left,
|
|
loc: getOperatorToken(left).loc,
|
|
messageId: "unexpectedMixedOperator",
|
|
data
|
|
});
|
|
context.report({
|
|
node: right,
|
|
loc: getOperatorToken(right).loc,
|
|
messageId: "unexpectedMixedOperator",
|
|
data
|
|
});
|
|
}
|
|
function check(node) {
|
|
if (TARGET_NODE_TYPE.test(node.parent.type) && isMixedWithParent(node) && !shouldIgnore(node)) {
|
|
reportBothOperators(node);
|
|
}
|
|
}
|
|
return {
|
|
BinaryExpression: check,
|
|
LogicalExpression: check
|
|
};
|
|
}
|
|
});
|
|
|
|
module.exports = noMixedOperators;
|